Skip to content

fix(ci): recover main quality gates and deterministic validation - #18345

Open
diegosouzapw wants to merge 157 commits into
mainfrom
fix/qg-main-recovery-candidate-20261026
Open

diegosouzapw wants to merge 157 commits into
mainfrom
fix/qg-main-recovery-candidate-20261026

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

The public main branch has failing quality checks that can make unrelated contributor PRs start red. This PR brings together the recovery work, deterministic validation, and gate contracts needed to distinguish inherited failures from regressions introduced by a contributor.

The current head is e7954576ded1491579b9b436da111d0d72670d2e. Its diff against the observed public main contains 2,167 paths, including the accumulated recovery changes. The final 29-path layer on the frozen 518a9cb0 basis includes:

  • Five targeted repairs: environment-documentation context, packaging of the build-progress helper, impacted-test selection for shared helpers, ESLint consumer fixtures, and the combo timeout fixture.
  • Observer parity with the canonical build producer, strict artifact consumption, build identity and independent package checks within the existing deadline.
  • Deterministic integration distribution through the existing four CI shards, with selector/wrapper contracts and the corresponding observer assertion updated to the final wiring.

The accumulated changes also cover test and data isolation, dependency provisioning and verification, process completion and resource cleanup, explicit i18n comparison context, and the documentation and skill contracts used by the gate. These remain subject to complete current-candidate validation.

⚠️ base-red inherited: #17267. HOLD — not approved for merge. Public refs/heads/main was re-resolved on 2026-11-04 at 26bf6812c06afb33abeb877160585050c0f5ca5d; its exact-base CI run and Quality run failed. This warning does not establish the cause of a failure on the new candidate.

Validation and remaining acceptance

  • The final repair layer covers 449 unique focused cases: 401 passing cases from 31 preserved results whose inputs were verified unchanged, plus all 48 cases in the corrected observer suite rerun successfully. This is a preserved-results synthesis, not a fresh 449-case run. The initial 448/449 result remains historical RED.
  • Formatting, normal commit hooks, and the post-commit check:test-masking check passed for the 29-path repair layer. Test masking compared the committed head with 518a9cb0; it does not certify the complete 2,167-path PR diff. The committed tree is f5073a8e1844bbeb1a7418c9ea36ca2213dd3342.
  • The earlier complete local observer on 518a9cb0 remains RED. Diagnostic runs and full validation of the composed candidate remain pending; focused results do not reclassify historical failures or certify real startup, complete suites, build, package or boot behavior.
  • The new head triggered CI and Quality Gates, both pull_request, attempt 1. API Route Typecheck, semgrep, opencode-plugin CI and opencode-provider CI were also triggered. Their initial observed state was queued; no current-candidate hosted PASS is claimed.
  • The PR merge candidate is 1bc7980174d8c7e9f4a536dc34f3e571dd2d76f7, with parents 26bf6812 and e7954576 and the same tree as the committed head. Admission must match this candidate and the exact run/attempt, and must be refreshed if the base or head changes.

protected_surface: true. The diff includes agent guidance, instruction mirrors and quality skill templates. Specific operator approval of the exact protected diff remains required before merge. The PR is ready for checks, with no auto-merge enabled. Full admission, required-check enforcement, incident closure, canaries, deployment and merge remain pending their acceptance steps. Overall status: PARTIAL / NOT CERTIFIED.

diegosouzapw and others added 30 commits October 25, 2026 20:48
Backport #17226 and use a registered Perplexity model in the delayed persistence fixture.

Co-authored-by: Paco Cartones <253313177+pacocartones@users.noreply.github.com>
Reconcile immutable OpenAPI baselines, required audits, hosted receipts,
workflow pins and cache trust, repository identity and test registration.

Co-authored-by: Bob.Hou <houminxi@gmail.com>
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: success
  • PR test policy: success

Coverage artifact was not available for this run.

@diegosouzapw diegosouzapw added the protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge label Nov 2, 2026

HouMinXi commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Could you check the full package timeout alongside the remaining validation for 5ef30a12? Its full pack-artifact lane still has a 20-minute budget. In today's main job, build:cli timed out after 1,201,732 ms on 55ccad49.

The main-green-report artifact contains the complete command receipts and assertion stacks:

  • Seven unit shards failed with 21 top-level failing tests. These include catalog responses returning 503 instead of 200, MITM cleanup state, filesystem fault injection, timing assertions, locale-dependent sorting, and Perplexity stream finalization. The Perplexity wrapper contains four failing child assertions.
  • Integration has 12 failures: batch E2E reports fetch failed / ECONNRESET; the other 11 inherit server-startup timeouts from the fingerprint and resilience suites' setup hooks.
  • The report's five HARD entries include the same build timeout under both package validation and build:cli. Boot was skipped because no valid build was produced, so those entries are not five independent defects.

This candidate already changes several relevant paths: isolated hosts fixtures, root-safe filesystem failure injection, fixed locale, throttle timing, child readiness, and early stream-finalizer registration. Those changes still need complete validation on the current candidate; the remaining failures cannot all be attributed to one network warning.

#18693's 40-minute package budget is now exercised on release 075d6e5: full package and installed-CLI boot validation passed. Please check whether that budget change belongs in this main companion and reconcile the artifact's failures with current-head coverage. The release result does not validate this candidate.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1e0e5ef-4a3f-4d73-9977-f433d168adec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protected-surface Touches an agent-instruction surface (AGENTS/CLAUDE/llm.txt/SKILL.md) — per-PR operator OK to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants